Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JWT Node): New node #9005

Merged
merged 9 commits into from Apr 10, 2024
Merged

Conversation

michael-radency
Copy link
Contributor

Summary

based on @Joffcom community node

Related tickets and issues

https://linear.app/n8n/issue/NODE-1252/jwt-node-new-node

@michael-radency michael-radency added node/new Creation of an entirely new node n8n team Authored by the n8n team labels Mar 29, 2024
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the URL we should add some tests as well.

packages/nodes-base/nodes/Jwt/Jwt.node.json Outdated Show resolved Hide resolved
Copy link

cypress bot commented Apr 10, 2024

2 flaky tests on run #4649 ↗︎

0 354 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 7227bf8fa4
Status: Passed Duration: 04:27 💡
Started: Apr 10, 2024 8:05 AM Ended: Apr 10, 2024 8:09 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9005 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 0a9f6b3 into master Apr 10, 2024
28 checks passed
@michael-radency michael-radency deleted the node-1252-jwt-node-new-node branch April 10, 2024 10:16
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
@janober
Copy link
Member

janober commented Apr 10, 2024

Got released with n8n@1.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants