Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add credential update and delete events to log streaming #9026

Merged
merged 1 commit into from Apr 8, 2024
Merged

feat: Add credential update and delete events to log streaming #9026

merged 1 commit into from Apr 8, 2024

Conversation

valya
Copy link
Contributor

@valya valya commented Apr 2, 2024

Summary

Add events for updating and deleting credentials

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 2, 2024
@valya valya mentioned this pull request Apr 2, 2024
Merged
@cypress Cypress
Copy link

cypress bot commented Apr 4, 2024

2 flaky tests on run #4577 ↗︎

0 345 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Project: n8n Commit: e0222d601b
Status: Passed Duration: 06:25 💡
Started: Apr 4, 2024 5:18 PM Ended: Apr 4, 2024 5:24 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  34-template-credentials-setup.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Template credentials setup > has all the elements on page Test Replay Screenshots Video

Review all test suite changes for PR #9026 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

✅ All Cypress E2E specs passed

@krynble krynble merged commit f4f0a36 into master Apr 8, 2024
28 checks passed
@krynble krynble deleted the pay-1483-add-credential-deleted-and-updated-to-log-streaming-events branch April 8, 2024 07:13
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Merged
@janober
Copy link
Member

janober commented Apr 10, 2024

Got released with n8n@1.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valya @janober @krynble