Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Github Node): Add option to get pull requests #9094

Merged
merged 2 commits into from Apr 15, 2024

Conversation

cyliu0
Copy link
Contributor

@cyliu0 cyliu0 commented Apr 9, 2024

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

The Get Issues are not enough for me. Add Get Pull Requests to GitHub Node.
image

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Apr 9, 2024
@Joffcom Joffcom changed the title feat(Github Node): add get pull requests feat(Github Node): Add support for Pull Requests Apr 11, 2024
@Joffcom Joffcom changed the title feat(Github Node): Add support for Pull Requests feat(Github Node): Add option to get pull requests Apr 11, 2024
@Joffcom
Copy link
Member

Joffcom commented Apr 11, 2024

Hey @cyliu0,

Thanks for the PR it looks good.

@Joffcom
Copy link
Member

Joffcom commented Apr 11, 2024

Hey @cyliu0,

Looks like there is a lint issue that needs to be resolved before we can merge this.

@cyliu0
Copy link
Contributor Author

cyliu0 commented Apr 12, 2024

@Joffcom I have fixed the lint issues

@cyliu0
Copy link
Contributor Author

cyliu0 commented Apr 15, 2024

@Joffcom Should anyone trigger the E2E check manually?

@Joffcom
Copy link
Member

Joffcom commented Apr 15, 2024

@cyliu0 it was waiting for me, Running now.

@Joffcom
Copy link
Member

Joffcom commented Apr 15, 2024

Hey @cyliu0,

Thanks for the PR, This will be available in the next release.

@Joffcom Joffcom merged commit 4d9000b into n8n-io:master Apr 15, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
@janober
Copy link
Member

janober commented Apr 17, 2024

Got released with n8n@1.38.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants