Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): Tolerate header name being empty #9138

Merged
merged 1 commit into from Apr 17, 2024
Merged

fix(HTTP Request Node): Tolerate header name being empty #9138

merged 1 commit into from Apr 17, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Apr 12, 2024

Summary

Don't throw error when header name is empty in HTTP Request Node, just don't send header

image

Related tickets and issues

https://linear.app/n8n/issue/NODE-1284/http-request-tolerate-headers-being-empty

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@cypress Cypress
Copy link

cypress bot commented Apr 12, 2024

2 flaky tests on run #4687 ↗︎

0 354 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: b481af41fa
Status: Passed Duration: 03:50 💡
Started: Apr 12, 2024 3:24 PM Ended: Apr 12, 2024 3:28 PM
Flakiness  30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor zoom should work after route changes > after switching between Editor and Workflow history and Workflow list Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #9138 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Apr 16, 2024
@Joffcom Joffcom added n8n team Authored by the n8n team and removed community Authored by a community member labels Apr 16, 2024
@elsmr elsmr merged commit f6c9dbf into master Apr 17, 2024
28 checks passed
@elsmr elsmr deleted the node-1284-http-request-tolerate-headers-being-empty branch April 17, 2024 07:45
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Merged
@janober
Copy link
Member

janober commented Apr 17, 2024

Got released with n8n@1.38.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elsmr @janober @maspio @Joffcom