Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Respond to Webhook Node): Fix issue stopping form trigger response #9157

Merged

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Apr 17, 2024

Summary

Updates check to include the form trigger node

Related tickets and issues

#9156

@Joffcom Joffcom changed the title fix(Respond to Webhook Node): fix issue stopping form trigger response fix(Respond to Webhook Node): Fix issue stopping form trigger response Apr 17, 2024
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Apr 17, 2024

3 failed and 1 flaky tests on run #4739 ↗︎

3 262 5 0 Flakiness 1

Details:

🌳 cli-import 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Project: n8n Commit: 1c212646a8
Status: Failed Duration: 04:20 💡
Started: Apr 22, 2024 11:38 AM Ended: Apr 22, 2024 11:42 AM
Failed  30-editor-after-route-changes.cy.ts • 1 failed test

View Output Video

Test Artifacts
Editor zoom should work after route changes > after switching between Editor and Workflow history and Workflow list Test Replay Screenshots Video
Failed  39-projects.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Projects > should handle workflows and credentials Test Replay Screenshots Video
Projects > should show correct projects, workflows and credentials for admin user Test Replay Screenshots Video
Failed  25-stickies.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  1-workflows.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  21-community-nodes.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 29 specs in Cypress Cloud.

Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video

Review all test suite changes for PR #9157 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Apr 17, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 6c63cd9 into master Apr 19, 2024
28 of 29 checks passed
@Joffcom Joffcom deleted the node-1305-respond-to-webhook-fails-with-form-trigger branch April 19, 2024 09:54
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@janober
Copy link
Member

janober commented Apr 24, 2024

Got released with n8n@1.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants