New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Respond to Webhook Node): Fix issue stopping form trigger response #9157
Merged
Joffcom
merged 1 commit into
master
from
node-1305-respond-to-webhook-fails-with-form-trigger
Apr 19, 2024
Merged
fix(Respond to Webhook Node): Fix issue stopping form trigger response #9157
Joffcom
merged 1 commit into
master
from
node-1305-respond-to-webhook-fails-with-form-trigger
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffcom
changed the title
fix(Respond to Webhook Node): fix issue stopping form trigger response
fix(Respond to Webhook Node): Fix issue stopping form trigger response
Apr 17, 2024
michael-radency
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 failed and 1 flaky tests on run #4739 ↗︎
Details:
30-editor-after-route-changes.cy.ts • 1 failed test
39-projects.cy.ts • 2 failed testsThe first 5 failed specs are shown, see all 29 specs in Cypress Cloud. cypress/e2e/5-ndv.cy.ts • 1 flaky test
Review all test suite changes for PR #9157 ↗︎ |
|
n8n-assistant
bot
added
community
Authored by a community member
node/improvement
New feature or request
labels
Apr 17, 2024
✅ All Cypress E2E specs passed |
Joffcom
deleted the
node-1305-respond-to-webhook-fails-with-form-trigger
branch
April 19, 2024 09:54
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates check to include the form trigger node
Related tickets and issues
#9156