Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Splunk Node): Retry attempts if no response from API call, better error with suggestion to use Retry On Fail #9176

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Apr 19, 2024

Summary

Splunk node: toString() method throwing errors when using with sid

  • added recovery attempts if no response
  • added itemIndex to errors
  • added pairedItem support

Related tickets and issues

https://community.n8n.io/t/splunk-retrieve-result-error/30145
https://linear.app/n8n/issue/NODE-753/splunk-node-tostring-method-throwing-errors-when-using-with-sid

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Apr 19, 2024
Co-authored-by: Elias Meire <elias@meire.dev>
Copy link

cypress bot commented Apr 24, 2024

Passing run #4757 ↗︎

0 356 12 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 68396299f9
Status: Passed Duration: 04:05 💡
Started: Apr 24, 2024 7:56 AM Ended: Apr 24, 2024 8:00 AM

Review all test suite changes for PR #9176 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 05a569c into master Apr 24, 2024
30 checks passed
@michael-radency michael-radency deleted the node-753-splunk-node-tostring-method-throwing-errors-when-using-with branch April 24, 2024 08:05
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@janober
Copy link
Member

janober commented Apr 24, 2024

Got released with n8n@1.39.0

despairblue pushed a commit that referenced this pull request Apr 26, 2024
… error with suggestion to use Retry On Fail (#9176)

Co-authored-by: Elias Meire <elias@meire.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants