Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Zammad Node): Add more options to the Organizations endpoint #9180

Merged
merged 3 commits into from Apr 22, 2024

Conversation

ayatnkw
Copy link
Contributor

@ayatnkw ayatnkw commented Apr 19, 2024

Summary

Added more options to add Organization details when creating/updating using the Zammad node:

  • shared : If true, the organization is shared with other instances.
  • domain: The domain associated with the organization.
  • domain_assignment: If true, assigns users based on their email domain.
  • active: If true, the organization is active.
  • vip: If true, the organization is marked as VIP.

See Zammad documentation for details.

Related tickets and issues

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024

CLA assistant check
All committers have signed the CLA.

@ayatnkw ayatnkw requested a review from Joffcom April 19, 2024 15:50
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 19, 2024
@ayatnkw ayatnkw changed the title fix(Update Zammad Node): Add more options to the Organizations endpoint fix(Zammad Node): Add more options to the Organizations endpoint Apr 19, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Apr 22, 2024

2 flaky tests on run #4743 ↗︎

0 356 12 0 Flakiness 2

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: 15c88d6839
Status: Passed Duration: 04:12 💡
Started: Apr 23, 2024 3:11 AM Ended: Apr 23, 2024 3:15 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9180 ↗︎

@Joffcom Joffcom changed the title fix(Zammad Node): Add more options to the Organizations endpoint feat(Zammad Node): Add more options to the Organizations endpoint Apr 22, 2024
@ayatnkw ayatnkw merged commit 15c88d6 into master Apr 22, 2024
30 checks passed
@ayatnkw ayatnkw deleted the add-options-zammad-org-endpoint branch April 22, 2024 13:25
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@janober
Copy link
Member

janober commented Apr 24, 2024

Got released with n8n@1.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants