Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix sessionId for manual chat trigger execution #9187

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Apr 22, 2024

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Due to renaming done in #8905, the manual chat trigger would incorrectly send pushRef instead of the expected sessionId. This PR reverts those changes for WorkflowLMChat component which trigger manual chat trigger execution

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 22, 2024
Copy link

cypress bot commented Apr 22, 2024

9 failed and 2 flaky tests on run #4745 ↗︎

9 214 5 0 Flakiness 2

Details:

🌳 pay-1484-update-permissions-with-project-scopes 🖥️ browsers:node18.12.0-chro...
Project: n8n Commit: 90d6057110
Status: Failed Duration: 05:21 💡
Started: Apr 23, 2024 8:20 AM Ended: Apr 23, 2024 8:26 AM
Failed  17-sharing.cy.ts • 8 failed tests

View Output Video

Test Artifacts
Sharing > should create C1, W1, W2, share W1 with U3, as U2 Test Replay Screenshots Video
Sharing > should create C2, share C2 with U1 and U2, as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should not have access to W2, as U3 Test Replay Screenshots Video
Sharing > should have access to W1, W2, as U1 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > should show correct projects, workflows and credentials for admin user Test Replay Screenshots Video
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 36 specs in Cypress Cloud.

Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video

Review all test suite changes for PR #9187 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit f5ccb5f into master Apr 23, 2024
29 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-170-cant-dynamically-set-session-id-in-window-buffer-memory branch April 23, 2024 07:20
EduardoPetrini pushed a commit to EduardoPetrini/n8n that referenced this pull request Apr 23, 2024
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@janober
Copy link
Member

janober commented Apr 24, 2024

Got released with n8n@1.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants