fix(editor): Node background for executing nodes in dark mode #9682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandreini
commented
Jun 10, 2024
| @@ -990,7 +990,7 @@ export default defineComponent({ | |||
| border-radius: 50px; | |||
|
|
|||
| &.executing { | |||
There was a problem hiding this comment.
@elsmr Do you get when this is used? I didi get it and couldn't test it
There was a problem hiding this comment.
n8n-assistant
bot
added
n8n team
gandreini
commented
Jun 10, 2024
| @@ -63,7 +63,7 @@ const styles = computed(() => { | |||
| display: flex; | |||
| align-items: center; | |||
| justify-content: center; | |||
| background: var(--canvas-node--background, var(--color-canvas-node-background)); | |||
| background: var(--canvas-node--background, var(--color-node-background)); | |||
There was a problem hiding this comment.
@elsmr where is this --canvas-node--background used?
There was a problem hiding this comment.
Can't find any usage, but let's keep it to be safe. Doesn't hurt as it always falls back
gandreini
commented
Jun 10, 2024
| @@ -62,13 +62,6 @@ $tag-text-color: var(--color-text-dark); | |||
| $tag-close-background-color: var(--color-text-light); | |||
| $tag-close-background-hover-color: var(--color-text-dark); | |||
|
|
|||
| // nodes | |||
There was a problem hiding this comment.
@elsmr I removed these saas vars as is seems like they are not used anymore, do you think it's fine?
2 flaky tests on run #5395 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9682 ↗︎
|
✅ All Cypress E2E specs passed |
gandreini
deleted the
node-1402-dark-mode-node-background-for-executing-nodes
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 11, 2024
* master: ci: Fix custom docker builds (no-changelog) (#9702) test: Fix e2e for projects missing instance owner (no-changelog) (#9703) ci: Refactor e2e tests to be less flaky (no-changelog) (#9695) feat(editor): Add move resources option to workflows and credentials on (#9654) fix: Introduce `HooksService` (#8962) fix(editor): Improve large data warning in input/output panel (#9671) ci(editor): Enforce type-safety in @n8n/chat builds as well (no-changelog) (#9685) fix(editor): Un-skip workflow save test (no-changelog) (#9698) refactor(core): Remove more dead code from event bus (no-changelog) (#9697) ci: Remove unused WaitTracker mocking (no-changelog) (#9694) feat: Update NPS Value Survey (#9638) refactor(core): Remove event bus channel (no-changelog) (#9663) refactor(core): Remove event bus helpers (no-changelog) (#9690) refactor(core): Merge event bus controllers and remove dead code (no-changelog) (#9688) ci: Fix e2e tests (no-changelog) (#9689) refactor(core): Use `@Licensed()` in event bus controller (no-changelog) (#9687) fix(editor): Node background for executing nodes in dark mode (#9682) fix(editor): Prevent saving already saved workflows (#9670) fix(editor): Fix node connection showing incorrect item count during … (#9684) refactor: Set up Cypress as pnpm workspace (no-changelog) (#6049)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the color of the execution nodes (previously white).
Related tickets and issues
https://linear.app/n8n/issue/NODE-1402/dark-mode-node-background-for-executing-nodes
Review / Merge checklist
(no-changelog)otherwise. (conventions)