Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Show multiple nodes in input pane schema view #9816

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jun 20, 2024

Summary

  • Show all previous nodes in tree view
  • Move search to header
  • Search filters items in schema view
  • Improve animations
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1383/improve-the-schema-view-to-make-data-from-all-previous-nodes-more

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@elsmr elsmr requested a review from cstuncsik June 20, 2024 09:12
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 20, 2024
cstuncsik
cstuncsik previously approved these changes Jun 20, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jun 20, 2024

4 flaky tests on run #5653 ↗︎

0 395 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: ba7e676b84
Status: Passed Duration: 05:14 💡
Started: Jun 24, 2024 3:31 PM Ended: Jun 24, 2024 3:37 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo renaming node using NDV Test Replay Screenshots Video

Review all test suite changes for PR #9816 ↗︎

@elsmr elsmr requested a review from cstuncsik June 24, 2024 08:56
cstuncsik
cstuncsik previously approved these changes Jun 24, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@elsmr elsmr requested a review from cstuncsik June 24, 2024 15:00
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit e51de9d into master Jun 24, 2024
26 checks passed
@elsmr elsmr deleted the node-1383-improve-the-schema-view-to-make-data-from-all-previous-nodes branch June 24, 2024 16:09
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
@janober
Copy link
Member

janober commented Jun 27, 2024

Got released with n8n@1.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants