fix(editor): Show error state correctly in options parameter with remote options #9836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
alexgrozav
previously approved these changes
Jun 24, 2024
|
✅ All Cypress E2E specs passed |
3 flaky tests on run #5674 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9836 ↗︎
…w-loading-placeholder-after
alexgrozav
previously approved these changes
Jun 24, 2024
|
✅ All Cypress E2E specs passed |
…w-loading-placeholder-after
alexgrozav
approved these changes
Jun 26, 2024
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1434-bug-loadoptions-continues-to-show-loading-placeholder-after
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show error state correctly in options parameter with remote options
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1434/bug-loadoptions-continues-to-show-loading-placeholder-after-fetch
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)