fix(Execute Workflow Node): Continue on fail behaviour not correctly implemented #9890
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ShireenMissi
changed the title
n8n-assistant
bot
added
n8n team
4 flaky tests on run #5733 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
5-ndv.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Credential Usage in Cross Shared Workflows > should only show credentials in their personal project for members |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9890 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the Execute Workflow Node with multiple items and the following parameters/settings:
The expected behaviour is to run the sub-workflow for each item and return an error for the items that fail. However, there is a bug that causes the execution to stop once an item fails.
Fix:
This PR fixes the issue by adding the error to the output instead of throwing it and returning early. This allows the sub-workflow to continue running for the remaining items even if one item fails.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1447/execute-workflow-continue-on-fail-not-correctly-implemented
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)