fix(core): Don't allow using credentials that are not part of the same project #9916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
valya
approved these changes
Jul 3, 2024
4 flaky tests on run #5755 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Langchain Integration > should add and use Manual Chat Trigger node together with Agent node |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9916 ↗︎
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-1650-bug-n8n-is-allowing-users-to-save-workflows-with-credentials
branch
Merged
|
Got released with |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was possible to use the API directly to add credentials to a workflow that were not owned by the same project that the workflow was owned by.
This is not a security issue, because the user could not have added credentials they don't have access to. The workflow would just have failed to run.
Nonetheless, this is a bug that should be fixed.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1650/bug-n8n-is-allowing-users-to-save-workflows-with-credentials-not
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)