Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include installer dir when looking for distfiles #34

Open
liback opened this issue Oct 30, 2022 · 0 comments
Open

Do not include installer dir when looking for distfiles #34

liback opened this issue Oct 30, 2022 · 0 comments

Comments

@liback
Copy link
Contributor

liback commented Oct 30, 2022

When installing nQuake the user is asked to decide where to install distfiles. However, the installer will also look for distfiles in the same directory as the installer .exe file. This is not intuitive and may cause problems if running the nQuake installer from the browser downloads folder that may at the same time contain old version of distribution files (especially for people maintaining nQuake).

See

${If} ${FileExists} "$EXEDIR\$R0"

Function .installSection
  Pop $R1 # distfile info
  Pop $R0 # distfile filename
  Call .checkDistfileDate
  ${If} ${FileExists} "$EXEDIR\$R0"
    DetailPrint "Extracting $R1, please wait..."
    nsisunz::UnzipToStack "$EXEDIR\$R0" $INSTDIR
  ${ElseIf} ${FileExists} "$DISTFILES_PATH\$R0"
[.......omitted for brevity]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant