Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.7 Support #623

Closed
renanBritz opened this issue Sep 6, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@renanBritz
Copy link

commented Sep 6, 2018

Hello!

Any plans on laravel 5.7 support?

Regards!

@nWidart

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2018

It's planned yes. I haven't had the time to do so myself. The migration should be very easy though.

@nWidart nWidart added the help wanted label Sep 18, 2018

@nWidart

This comment has been minimized.

Copy link
Owner

commented Sep 18, 2018

Master branch is using 5.7, but some tests fail for an unknown reason.

Build log: https://travis-ci.org/nWidart/laravel-modules/jobs/428662632

If someone has an idea, it would be much appreciated.

@KABBOUCHI

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2018

There a exception ( enabled it using $this->withExceptionHandling();)

1) Nwidart\Modules\Tests\Commands\ModuleMakeCommandTest::it_still_generates_module_if_it_exists_using_force_flag
Error: Class 'Modules\Blog\Providers\BlogServiceProvider' not found

/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:208
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:144
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:61
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/Laravel/Module.php:27
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/Module.php:251
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/FileRepository.php:299
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/Providers/BootstrapServiceProvider.php:22
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:572
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/ModulesServiceProvider.php:38
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/LaravelModulesServiceProvider.php:15
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:87
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:31
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/Container.php:564
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:793
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:776
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:777
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/BootProviders.php:17
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:310
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:202
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/TestCase.php:73
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/Concerns/Testing.php:59
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/TestCase.php:41
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/tests/BaseTestCase.php:12
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/tests/Commands/ModuleMakeCommandTest.php:23
@nWidart

This comment has been minimized.

Copy link
Owner

commented Sep 20, 2018

Indeed, but why is the question. When I stopped the test in mid process, I could see the module there.

@jesseschutt

This comment has been minimized.

Copy link

commented Sep 26, 2018

I was wondering if this is still failing on 5.7? I forked the repository and the tests are passing locally. Thank you!

@nWidart

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2018

Support is already available if you use 4.0-dev, but i'll tag it at some point soon.

@nWidart

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2018

4.0.0 was just tagged. Thanks again for the help @KABBOUCHI !

@nWidart nWidart closed this Sep 30, 2018

@rajath-ramachandran

This comment has been minimized.

Copy link

commented Jun 12, 2019

Hai im getting an error on laravel 5.7 while running publish command, like
"Argument 2 passed to Illuminate\Routing\UrlGenerator::__construct() must be an instance of Illuminate\Http\Request, null given"
Please Help

@nWidart

This comment has been minimized.

Copy link
Owner

commented Jun 12, 2019

Strange error. You can try to debug it by understanding why it's getting null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.