Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor data seeding #329

Closed
nabeelio opened this issue Jul 18, 2019 · 0 comments
Closed

Refactor data seeding #329

nabeelio opened this issue Jul 18, 2019 · 0 comments
Milestone
beta-2

Comments

@nabeelio
Copy link
Owner

nabeelio commented Jul 18, 2019 •
edited
Loading

Refactor how data seeding is done... it's confusing and in multiple places. This will also help with the syncing of these seeds/settings.

  • Move the sample data into Database/seeds/sample directory. Confusing as to what is sample/dev specific vs what's entirely required during an install
  • DatabaseSeeder calls should move into Services/Installer/SeederService.php
  • dev-install should call the seeder that's run during the install/update so that base data is there
@nabeelio nabeelio added this to the beta milestone Jul 18, 2019
@nabeelio nabeelio mentioned this issue Aug 2, 2019
Merged
@nabeelio nabeelio closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
beta-2
Development

No branches or pull requests
1 participant
@nabeelio