Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Base Map for Modules #836

Closed
YashGovekar opened this issue Sep 24, 2020 · 1 comment · Fixed by #837
Closed

Render Base Map for Modules #836

YashGovekar opened this issue Sep 24, 2020 · 1 comment · Fixed by #837

Comments

@YashGovekar
Copy link
Contributor

YashGovekar commented Sep 24, 2020

I am making a new module related to leaflet map.

I figured out that in resources/js/maps/index.js, there is no function for a basic map that can be used ready made in blade which is available in base_map.js

I edited index.js to look like this and then run npm build prod.

import render_airspace_map from './airspace_map';
import render_live_map from './live_map';
import render_route_map from './route_map';
import render_base_map from './base_map';

require('leaflet.geodesic');
require('leaflet-rotatedmarker');

window.L = require('leaflet');

export {
  render_airspace_map,
  render_live_map,
  render_route_map,
  render_base_map,
};

So now if I release my new module, every user will have to do npm run prod before using the module.

So I request you to please update the index.js so that it can render a basic/base map for developers without running any commands.

@nabeelio
Copy link
Owner

What specifically do you want added/changed? Can you submit a pull request?

@nabeelio nabeelio linked a pull request Sep 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants