Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flights Import : Edited Fares | CSV Import (Bug Report) #974

Closed
FatihKoz opened this issue Dec 29, 2020 · 2 comments · Fixed by #1379
Closed

Flights Import : Edited Fares | CSV Import (Bug Report) #974

FatihKoz opened this issue Dec 29, 2020 · 2 comments · Fixed by #1379
Labels
Milestone

Comments

@FatihKoz
Copy link
Contributor

When using import function, fares with changed/edited values are not imported correctly.

Exported file contains YG?price=75% as the value for fares field (which is the reduced fare price for that flight and only the prices was changed rest stays inherited). But when importing it is not handled properly and a new fare is created with a name and id YG?price=75%

Version
7.0.0-dev+201223.18e1d6

To Reproduce
Just export your flights and check flights with edited fares, then import back the same csv.

Expected behavior
They should be imported with the same fare code (YG) and they should have the edits mentioned (?price=75%) in the csv. If this is not possible then we should use only the fare and any edits should be disregarded (?=....)

@nabeelio nabeelio added the bug label Apr 12, 2021
@nabeelio nabeelio added this to the 7.0.0 milestone Apr 12, 2021
@FatihKoz FatihKoz changed the title Flights Import (Edited Fares) Flights Import : Edited Fares | CSV Import (Bug Report) Jun 11, 2021
@FatihKoz
Copy link
Contributor Author

Above issue happens while importing subfleets with edited fares too. With the issue being open it is not possible to export and re-import flights/subfleets (or import new ones) properly once you edit their fares.

@lesmar54
Copy link
Contributor

lesmar54 commented Sep 18, 2021

I am going to look into this now that I have flights with fare codes to test with. Flights and the Fares table seemed to be linked with a file called 'flight_fare' which has the details of the flight and the fare codes used
Screenshot 2021-09-18 at 17 01 32
A similar ID is attached to the flights table
Screenshot 2021-09-18 at 17 05 03
This code for the ID looks like a string of hexadecimal characters and I need to find out how these ID strings are created as what might be happening is that when the data is re-imported there is no match to this table to update the data from the fares string in the flights.csv. This is only a theory at the moment and I will add to this if I find anything more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants