Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart Migration w/o annotations #32

Closed
wants to merge 6 commits into from
Closed

Dart Migration w/o annotations #32

wants to merge 6 commits into from

Conversation

MateusAmin
Copy link

@MateusAmin MateusAmin commented Mar 15, 2021

#21

Not tested, but passes analysis. I am using in my own project and will follow up with opinions.

I used the Dart migration tools without any annotation coloring the results. Then made some patches here and there. You may want to go through it yourself as there is an opportunity to make the API a bit safer by shifting types to be non-nullable. Without annotations the migration tends to just make things explicitly null able.

Also, probably a good idea to major version bump and add a -beta tag to the version if you feel this is still in beta.

@MateusAmin
Copy link
Author

It works with some minor use changes, would need to update the examples.

Honestly, this is a pretty low effort PR from my end. If someone has time to really think things through that would be best.

@nabil6391
Copy link
Owner

hi @MateusAmin , really busy month going on for me, I wont be able to CR soon. Hope you understand

@MateusAmin
Copy link
Author

Absolutely. If I where less busy I would have made you a cleaner PR. Hopefully, some other users with more time might step in.

With my use case I am going to end up with a custom library but this really helped me get off to a quick start. I am grateful for all the work you put into this so far.

@stefanschaller
Copy link

What is the progress right now?
My company would like to use / fork this repo to do something awesome (When Null-Safefy is done and stable)

Is any help needed?

@nabil6391
Copy link
Owner

I have pushed some codes to master for a change. After merging I will make this null safe

@vin-fandemand
Copy link

Hi folks, any update on the null safe release?

@nabil6391
Copy link
Owner

NullSafety version has been released guys, thanks for the wait
Version: 1.0.0-nullsafety.1

@MateusAmin MateusAmin closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants