Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin and Extensions support #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dhruvnagarajan
Copy link

@dhruvnagarajan dhruvnagarajan commented Oct 29, 2019

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Provide permissions using the :sample app

Test Configuration:

  • Hardware: Emulator
  • SDK: 29

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dhruvnagarajan dhruvnagarajan changed the title Convert PermissionsHandler and PermissionsActivity to Kt Add Kotlin and Extensions support Oct 29, 2019
@ytheekshana
Copy link

is this stable?

@dhruvnagarajan
Copy link
Author

@ytheekshana yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants