NOJIRA: Update RuboCop and rerun

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-05-25 17:11:33 +1000 using RuboCop version 0.40.0.
+# on 2016-08-12 17:48:46 +1000 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -104,7 +104,11 @@ Style/BracesAroundHashParameters:
 # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
 Style/CaseIndentation:
-  Enabled: false
+  Exclude:
+    - 'app/mailers/comment_mailer.rb'
+    - 'app/models/identifiable_by_doi.rb'
+    - 'lib/exsite9.rb'
+    - 'lib/media.rb'
 
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: nested, compact
@@ -159,11 +163,6 @@ Style/CommentIndentation:
     - 'config/initializers/squeel.rb'
     - 'lib/media.rb'
 
-# Cop supports --auto-correct.
-Style/DeprecatedHashMethods:
-  Exclude:
-    - 'spec/support/select2.rb'
-
 Style/Documentation:
   Enabled: false
 
@@ -213,7 +212,10 @@ Style/IfUnlessModifier:
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
 Style/IndentHash:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'lib/exsite9.rb'
+    - 'lib/nabu_spreadsheet.rb'
 
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -256,7 +258,9 @@ Style/MethodCallParentheses:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
 Style/MethodDefParentheses:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+    - 'spec/support/select2.rb'
 
 Style/MultilineBlockChain:
   Exclude:
@@ -283,15 +287,20 @@ Style/MultilineMethodCallBraceLayout:
 
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: aligned, indented
+# SupportedStyles: aligned, indented, indented_relative_to_receiver
 Style/MultilineMethodCallIndentation:
-  Enabled: false
+  Exclude:
+    - 'app/models/user.rb'
 
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: aligned, indented
 Style/MultilineOperationIndentation:
-  Enabled: false
+  Exclude:
+    - 'app/models/collection.rb'
+    - 'app/models/item.rb'
+    - 'app/services/item_catalog_service.rb'
+    - 'app/services/item_destruction_service.rb'
 
 # Cop supports --auto-correct.
 Style/MutableConstant:
@@ -336,6 +345,16 @@ Style/Not:
 Style/NumericLiterals:
   MinDigits: 15
 
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'app/models/collection.rb'
+    - 'app/models/item.rb'
+    - 'lib/exsite9.rb'
+    - 'lib/monkeypatch.rb'
+
 # Cop supports --auto-correct.
 # Configuration parameters: AllowSafeAssignment.
 Style/ParenthesesAroundCondition:
@@ -376,6 +395,11 @@ Style/PredicateName:
     - 'app/models/item.rb'
     - 'lib/media.rb'
 
+# Cop supports --auto-correct.
+Style/PreferredHashMethods:
+  Exclude:
+    - 'spec/support/select2.rb'
+
 # Cop supports --auto-correct.
 Style/Proc:
   Exclude:
@@ -385,7 +409,8 @@ Style/Proc:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
-  Enabled: false
+  Exclude:
+    - 'lib/monkeypatch.rb'
 
 # Cop supports --auto-correct.
 Style/RedundantBegin:
@@ -434,13 +459,6 @@ Style/SpaceAfterComma:
     - 'lib/media.rb'
     - 'spec/controllers/essences_controller_spec.rb'
 
-# Cop supports --auto-correct.
-Style/SpaceAfterNot:
-  Exclude:
-    - 'app/controllers/users_controller.rb'
-    - 'lib/exsite9.rb'
-    - 'spec/support/select2.rb'
-
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleInsidePipes, SupportedStyles.
 # SupportedStyles: space, no_space
@@ -452,7 +470,9 @@ Style/SpaceAroundBlockParameters:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: space, no_space
 Style/SpaceAroundEqualsInParameterDefault:
-  Enabled: false
+  Exclude:
+    - 'lib/tasks/archive.rake'
+    - 'spec/support/select2.rb'
 
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
@@ -500,7 +520,8 @@ Style/SpaceInsideParens:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: use_perl_names, use_english_names
 Style/SpecialGlobalVars:
-  Enabled: false
+  Exclude:
+    - 'lib/media.rb'
 
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
@@ -516,6 +537,13 @@ Style/Tab:
   Exclude:
     - 'app/models/identifiable_by_doi.rb'
 
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
+# SupportedStyles: require_parentheses, require_no_parentheses
+Style/TernaryParentheses:
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
 # SupportedStyles: comma, consistent_comma, no_comma
@@ -554,14 +582,20 @@ Style/VariableInterpolation:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: snake_case, camelCase
 Style/VariableName:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/page_controller.rb'
+    - 'app/models/identifiable_by_doi.rb'
+    - 'lib/exsite9.rb'
 
 # Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles, WordRegex.
+# Configuration parameters: EnforcedStyle, SupportedStyles, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
-  EnforcedStyle: percent
-  MinSize: 4
+  Exclude:
+    - 'app/admin/catalog_report.rb'
+    - 'db/migrate/20121027032001_add_timestampes_to_essences.rb'
+    - 'db/schema.rb'
+    - 'spec/lib/nabu_spreadsheet_spec.rb'
 
 # Cop supports --auto-correct.
 Style/ZeroLengthPredicate:

Gemfile.lock

@@ -66,7 +66,7 @@ GEM
     arbre (1.0.1)
       activesupport (>= 3.0.0)
     arel (3.0.3)
-    ast (2.2.0)
+    ast (2.3.0)
     bcrypt-ruby (3.1.2)
     better_errors (1.1.0)
       coderay (>= 1.0.0)
@@ -246,7 +246,7 @@ GEM
     paper_trail (2.7.1)
       activerecord (~> 3.0)
       railties (~> 3.0)
-    parser (2.3.1.0)
+    parser (2.3.1.2)
       ast (~> 2.2)
     poltergeist (1.9.0)
       capybara (~> 2.1)
@@ -328,8 +328,8 @@ GEM
       rspec-core (~> 2.12.0)
       rspec-expectations (~> 2.12.0)
       rspec-mocks (~> 2.12.0)
-    rubocop (0.40.0)
-      parser (>= 2.3.1.0, < 3.0)
+    rubocop (0.42.0)
+      parser (>= 2.3.1.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
@@ -391,7 +391,7 @@ GEM
     uglifier (1.3.0)
       execjs (>= 0.3.0)
       multi_json (~> 1.0, >= 1.0.2)
-    unicode-display_width (1.0.5)
+    unicode-display_width (1.1.0)
     unicorn (4.6.0)
       kgio (~> 2.6)
       rack