Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'remove' command exception #111

Merged
merged 1 commit into from Oct 19, 2022
Merged

Fixed 'remove' command exception #111

merged 1 commit into from Oct 19, 2022

Conversation

doiska
Copy link
Contributor

@doiska doiska commented Oct 19, 2022

Hi! I found a bug in the stable version of Ultra, when using "ultra remove package-name" it throws an exception if not found in peerDependencies.

[Ultra] v0.7.0 (83.54ms)
file:///C:/Users/doiska/Documents/Tools/nvm/v16.16.0/node_modules/ultra-pkg/build/commands/remove.js:15
        delete pkg.peerDependencies[arg];
                                    ^

TypeError: Cannot convert undefined or null to object
    at remove (file:///C:/Users/doiska/Documents/Tools/nvm/v16.16.0/node_modules/ultra-pkg/build/commands/remove.js:15:37)
    at commands (file:///C:/Users/doiska/Documents/Tools/nvm/v16.16.0/node_modules/ultra-pkg/build/commands/index.js:107:16)

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fnpm ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 1:50PM (UTC)

@nachoaldamav
Copy link
Owner

Oh thanks!! I didn't check the remove command 😅

@nachoaldamav nachoaldamav merged commit 2ba9f3a into nachoaldamav:development Oct 19, 2022
@nachoaldamav
Copy link
Owner

I will merge into main later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants