Add support for multiline comments. #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I Changed the _SQL_COMMENT regex in `aiosql/query_loader.py` to work on single and multiline `/* */` style comments. I added a new test for it in `tests/test_loading.py` to show that it didn't break the previous behavior.
|
There is an formatting issue so that ISTM that the test could try nested stuff |
|
The feature does not seem to work, eg with: /* definition in comment should be ignored
-- name: hello
SELECT 'hello';
*/seems to create a |
|
Implemented in current dev branch. Will be merged and released later with 8.0. The implementation is less straightforward than this patch expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Changed the _SQL_COMMENT regex in
aiosql/query_loader.pyto work on single and multiline/* */style comments. I created a new test for it intests/test_loading.pyto show that it didn't break the previous behavior.