E and e exponent symbols are wrongly interpreted as dates

[nacnudus]

E.g. 0E1.

Reported by @da11an (thanks!) in #24 (comment) and #51

[nacnudus]

Some tests here https://github.com/andersnm/ExcelNumberFormat/blob/ba055b3ee7fa87abfeb2e26f7f46fbb09e22ea0c/test/ExcelNumberFormat.Tests/Class1.cs

[da11an]

Hi @nacnudus, is format detection part of this repo or a dependency? What file or dependency? I'd love to help.

[nacnudus]

Hi, sorry for still not having fixed this. The bug is in here:

tidyxl/src/date.h

Line 79 in 2650076

inline bool isDateFormat(std::string x) {

See also readxl tidyverse/readxl#388

[da11an]

I tried defining a date format in excel as 0.0e+0 but it wasn't allowed, but 0.0E+0 was. So I don't think there's a conflict here with lowercase e usage for era/year. Uppercase for scientific notation, lowercase for era. I'll submit a pull request.

Edit: I'm not allowed to branch or make a pull request. To fix, remove line 84 in tidyxl/src/date.h: CASEI('E'):