Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to limit number of digits for hours #101

Closed
Herz3h opened this issue Oct 28, 2020 · 5 comments
Closed

Ability to limit number of digits for hours #101

Herz3h opened this issue Oct 28, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@Herz3h
Copy link
Contributor

Herz3h commented Oct 28, 2020

Is your feature request related to a problem? Please describe.
Currently you can have as many digits in hours as you want. And this is annoying since, sometimes:

  • You don't want users to type in more than N digits for hours
  • Allowing unlimited number of digits for hours, doesn't autoswitch to minute after being done typing hours

Describe the solution you'd like
Attribute or js option to specify number of maximum digits for hours (by default set to infinite for BC)

Describe alternatives you've considered
An alternative would be, binding TAB key so you can easily switch between hours and minutes, and so on (I know arrow key do that, but they are too far away from left side of keyboard, and imo not very intuitive)

Additional context

@nadchif nadchif added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs labels Nov 8, 2020
@nadchif
Copy link
Owner

nadchif commented Nov 8, 2020

UPDATE: Thanks to @AlyxMoon , Tab key support has been added.

TODO: Implement

Attribute or js option to specify number of maximum digits for hours (by default set to infinite for BC)

@AlyxMoon
Copy link
Contributor

AlyxMoon commented Nov 8, 2020

I will grab this.

@tanishkachitnis22
Copy link

Is this still open for grabs I would love to grab

@nadchif
Copy link
Owner

nadchif commented Aug 20, 2021

@tanishkachitnis22 thank you, please take a look at #104 first

@nadchif nadchif mentioned this issue Nov 18, 2021
Merged
@nadchif
Copy link
Owner

nadchif commented Nov 18, 2021

This feature is now partially implemented in version 2.3.4. The behavior now is the picker will figure out the maximum hour digits based on the max-duration-value provided. By default the max-duration-value will be set to 99:59:59, hence setting the maximum hour digits to 2

@nadchif nadchif closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

4 participants