Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several (nearly) identical missions on offer (intended?) #2316

Closed
BM-W1 opened this issue Apr 3, 2023 · 4 comments
Closed

several (nearly) identical missions on offer (intended?) #2316

BM-W1 opened this issue Apr 3, 2023 · 4 comments
Labels
Priority-Medium Affects important parts of the game hampering the player's experience. Type-Defect Issue relates to a defect in the game that has to be corrected.

Comments

@BM-W1
Copy link

BM-W1 commented Apr 3, 2023

Please see the attached screenshot.
Missions: By accident there are 2 patrols of the Dune system and 3 convoys to Selphod. I doubt that these multiple (similar) instances are intended.

A small general feedback besides that issue: great game, great stories/missions, great dialogues! You're doing a brilliant job!
Screenshot_20230403_152525

@bobbens
Copy link
Member

bobbens commented Apr 3, 2023

What's likely happening is that there are few potential targets for patrols or convoy escorting. So if it generates a patrol mission, it may only have 1 potential "valid" patrol route. Since the patrol missions are independent of each other, you'll get multiple patrol missions being generated exactly the same. I agree this is an issue, but the solution is a bit tricky, as we need to somehow have the missions understand the other generated missions and try to minimize overlap.

Possible solutions I can think of:

  1. Extend the claim API to allow more fine-grained overlap detection so that you can have patrol missions not generate overlapping with each other.
  2. Use the cache system to manage overlapping mission stuff to an extent. Would be a bit tricky, but should be possible with a high priority helper event to set up the cache (or just use some sort of spob-based indexing).
  3. Relax the requirements for missions more so it is less likely that they overlap.

@bobbens bobbens added Type-Defect Issue relates to a defect in the game that has to be corrected. Priority-Medium Affects important parts of the game hampering the player's experience. labels Apr 3, 2023
@bobbens
Copy link
Member

bobbens commented Nov 10, 2023

OK, I've implemented solution 2. for cache-based checking. However, I only implemented it for patrol + trader escort missions at the moment. Do you think this should be implemented for other missions too?

@BM-W1
Copy link
Author

BM-W1 commented Nov 10, 2023

I believe the restriction to patrol and trader escort missions should do it. That is fine. Actually, I cannot remember other cases where this popped up in a way that distorts the intentions of missions.

@bobbens
Copy link
Member

bobbens commented Nov 10, 2023

OK, great! I'll close the issue then, thanks! If you see any other extreme case, it can be also added.

@bobbens bobbens closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-Medium Affects important parts of the game hampering the player's experience. Type-Defect Issue relates to a defect in the game that has to be corrected.
Projects
Status: Done
Development

No branches or pull requests

2 participants