Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate as much thread-local state as possible #49

Closed
nafg opened this issue Feb 3, 2012 · 2 comments
Closed

Eliminate as much thread-local state as possible #49

nafg opened this issue Feb 3, 2012 · 2 comments
Assignees
Labels
Milestone

Comments

@nafg
Copy link
Owner

nafg commented Feb 3, 2012

Perhaps use scala-query's pattern: pass around implicitly where possible, or provide an opt-in global implicit for thread-local state.

@nafg
Copy link
Owner Author

nafg commented Jun 12, 2013

After a great conversation with Alexey Romanov, it's become clear that thread-local is never correct. The new architecture should look like this:
Javascript is sent to a Page.
There can be many possible transport mechanisms, with various characteristics.
Page tracks the "currently available" transports (plural) and chooses the most efficient.

@nafg
Copy link
Owner Author

nafg commented Jun 24, 2013

Fixed on branch v0.4.0 in commit 18b49c6

@ghost ghost assigned nafg Jun 25, 2013
@nafg nafg closed this as completed Dec 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant