Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logo proposal #13

Closed
mansya opened this issue Aug 11, 2018 · 25 comments
Closed

New logo proposal #13

mansya opened this issue Aug 11, 2018 · 25 comments

Comments

@mansya
Copy link
Contributor

mansya commented Aug 11, 2018

Good day Sir I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before i begin my design. Hoping for your positive feedback. Thanks

@nafiesl
Copy link
Owner

nafiesl commented Aug 12, 2018

Hi @mansya, it's a good news for me. Sure. I really thank you for designing a logo for this project as a gift. Just let me know if you need some detailed information about this project.

Thanks again.

@mansya
Copy link
Contributor Author

mansya commented Aug 12, 2018

hi sir. I have designed a logo. do you like it ? if yes, which one do you like? let me know if there is something you want to change.
grosir obat

@nafiesl
Copy link
Owner

nafiesl commented Aug 12, 2018

Thanks @mansya,

I think it represent enough for the medicine store. So those options only different on coloring. I think i choose number 4.

What about if we have an additional (little) opensource logo? And I don't think we need dark border on top and bottom.

shutter_20180812-003

What do you think?

@mansya
Copy link
Contributor Author

mansya commented Aug 12, 2018

yes. I will remove the top and buttom borders

@mansya
Copy link
Contributor Author

mansya commented Aug 12, 2018

you choice number 4. I will make pull requests immediately

grosir obat

@nafiesl
Copy link
Owner

nafiesl commented Aug 12, 2018

Wait @mansya, have you read all my comment above?
"What about if we have an additional (little) opensource logo?"
What do you think?

@mansya
Copy link
Contributor Author

mansya commented Aug 13, 2018

about additional open source logos. Yes sure. What is the logo? can i see it or explain to me?

@nafiesl
Copy link
Owner

nafiesl commented Aug 13, 2018

yes, I am indonesian 😃

@mansya
Copy link
Contributor Author

mansya commented Aug 13, 2018

Salam kenal. Saya juga seorang indonesia. Anda dapat menjelskannya dalam bahasa indonesia 😃

@nafiesl
Copy link
Owner

nafiesl commented Aug 13, 2018

Hahaha, siap mas @mansya. Salam kenal.

Jadi saya fikir, ada baiknya kita tambahkan logo open source di kecil di logo ini.

  1. Posisinya, misal di posisi gambar di bawah (atau dimanapun yang mas mansya rasakan cocok).
  2. Untuk ukurannya juga sesuaikan dengan feel mas Mansya saja.

shutter_20180812-003a

https://www.google.co.id/search?q=open+source+logo&tbm=isch

shutter_20180813-001

@mansya
Copy link
Contributor Author

mansya commented Aug 13, 2018

Ok mas. Untuk warna nya saya gunakan warna apa mas ?

@nafiesl
Copy link
Owner

nafiesl commented Aug 13, 2018

Warna logo open sourcenya ikuti warna aslinya mas, mungkin ini ya:
Outer line: #009D42
Inner: #00C54B

@mansya
Copy link
Contributor Author

mansya commented Aug 14, 2018

maaf mas. kemarin saya offline. bagaimana tentang ini.
grosir obat 2

langsung mas pilih saja. biar saya buat pull requests mas. terimakasih mas.

@nafiesl
Copy link
Owner

nafiesl commented Aug 14, 2018

Yang kanan oke mas. Silakan Pull Request.

@mansya
Copy link
Contributor Author

mansya commented Aug 14, 2018

mas. saya sudah membuat pull requests. silahkan di periksa.
dan saya juga telah mengupload semua file nya link ini.
https://drive.google.com/open?id=1g7fj5nRtogDydi2c2bjDU6V_nyc64dzD

@nafiesl
Copy link
Owner

nafiesl commented Aug 14, 2018

Terima kasih mas @mansya akan saya review PR nya mas.

@mansya
Copy link
Contributor Author

mansya commented Aug 15, 2018

saya sedikit bingung dengan pull requets itu mas. apa yang harus saya lakukan ?

@nafiesl
Copy link
Owner

nafiesl commented Aug 15, 2018

Pada dasarnya, ketika buat pull request, kita tinggal tunggu pemilik repo untuk me-review pull request (PR) itu mas. Bisa jadi:

  • PR di-review (diskusi dulu sebelum diterima atau ditolak)
  • PR di-close (ditolak)
  • PR di-merge (diterima)
  • Commit di PR dikontribusi (ditambah) oleh pemilik repo, seperti contoh ini.

@mansya
Copy link
Contributor Author

mansya commented Aug 15, 2018

oh. terimakasih penjelasan nya mas. jadi merepotkan ini :-D
apakah ini sudah bisa saya ajukan kembali ?
atau ada sesuatu yang harus saya lakukan lagi ?

@nafiesl
Copy link
Owner

nafiesl commented Aug 15, 2018

Sama-sama mas Mansya. Tidak perlu diajukan lagi mas. Cukup 1 PR ini saja. Nanti kalau sudah OK saya akan merge. Nanti mas Mansya akan dapat notifikasi ketika sudah dimerge.

@mansya
Copy link
Contributor Author

mansya commented Aug 15, 2018

jadi mas saya tidak perlu melakukan apa apa lagi ini mas ? hanya tunggu notifikasi dari mas saja ?

@nafiesl
Copy link
Owner

nafiesl commented Aug 15, 2018

Betul sekali mas.

@mansya
Copy link
Contributor Author

mansya commented Aug 15, 2018

terimakasih mas.

@nafiesl
Copy link
Owner

nafiesl commented Aug 15, 2018

Saya yang terima kasih banyak mas, kontribusi yang mantap mas @mansya.
Kita sudah tambahkan juga logonya di halaman login.

shutter_20180815-001

@nafiesl nafiesl closed this as completed Aug 15, 2018
@mansya
Copy link
Contributor Author

mansya commented Aug 15, 2018

sama sama mas nafiesl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants