Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armv8 #50

Closed
sebdanielsson opened this issue Apr 26, 2021 · 8 comments
Closed

armv8 #50

sebdanielsson opened this issue Apr 26, 2021 · 8 comments

Comments

@sebdanielsson
Copy link

Are there any plans for armv8 binaries? Tried to install this onto my odroid-n2 via AUR but said this software wasn't available for my architecture.

@f-koehler
Copy link
Contributor

Hi @sebdanielsson,
I created both of the packages in the AUR. I limited the architecture to x86_64 this I was only able to test it on that architecture yet. However, I do not see any reason why the code should not compile on ARMv8 as well (or any other platform targeted by the go compiler).

I updated the PKGBUILD in the AUR accordingly. Can you help me test and just try to install it again? Hopefully no modifications are necessary.

@sebdanielsson
Copy link
Author

Was just about to try it but it seems AUR is having issues atm..😅

@naggie
Copy link
Owner

naggie commented Apr 26, 2021

ARMv8 should be fine -- there is also a prebuilt binary for ARMv5: https://github.com/naggie/dsnet/releases/download/v0.5/dsnet-linux-arm5 which (I think) should work with ARMv8 too.

Else, indeed the AUR package which builds from scratch should now work thanks to @f-koehler .

@sebdanielsson
Copy link
Author

It's now working great through the AUR, thanks😊

Would still be nice with a pre-built arm64 binary for the next release👍

@naggie
Copy link
Owner

naggie commented Apr 26, 2021

That depends -- if the ARMv5 binary works in a 64 bit world then I'd say it's simpler/better to ship fewer binaries, as speed isn't a concern

@f-koehler
Copy link
Contributor

ARM byte-code compatibility is not very straightforward according to my brief research just yet (see e.g. Wikipedia). However, when using the PKGBUILD from the AUR the code should get compiled for your current architecture. If not, then this would be a bug in the PKGBUILD which should be fixed.

Whether @naggie wants to have other builds as well is up to him. At some point one might think about creating a GitHub action to compile the code across multiple architectures when a release is drafted and automatically attach the build artifacts. But that would require quite some work.

@naggie
Copy link
Owner

naggie commented Apr 30, 2021

In that case I'll add the binary next time I make a release. Let's leave this issue open for that.

Ideally I'd have github actions set up for CI as well as releases -- currently testing is manual which isn't ideal. It would make a great PR if someone gets time though :)

@f-koehler f-koehler mentioned this issue May 3, 2021
@naggie
Copy link
Owner

naggie commented May 6, 2021

I've added an arm64 binary to the v0.6 release 👍

@naggie naggie closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants