Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some gcc-7.3 warnings #365

Merged
merged 8 commits into from Jun 20, 2018
Merged

Conversation

mjtrangoni
Copy link
Contributor

I fixed some trivial gcc warnings. Please feel free to merge or cherry-pick some.

Thanks!

@hedenface hedenface changed the base branch from master to maint March 16, 2018 12:22
@hedenface
Copy link
Contributor

Thanks! Can you resolve the conflicts for maint so that I can review and merge?

@hedenface hedenface self-requested a review March 16, 2018 12:22
@hedenface hedenface added this to the 2.2.2 milestone Mar 16, 2018
@mjtrangoni
Copy link
Contributor Author

@hedenface thanks! It should be working now. I forgot you work with the maint branch.

@mjtrangoni
Copy link
Contributor Author

@hedenface this is a little chaos here, I will be fixing and rebasing this soon.
What's about setting up TravisCI here too?

@hedenface
Copy link
Contributor

I had asked @box293 to look into creating one for plugins. If you'd like to work on that, feel free!

All of the OSS projects will have some form of testing in the next few months - along with a more consistent layout and the beginnings of consistency throughout the codebase(s). I'm actually working on the style guide for Core as we speak and that should be available soon.

@hedenface hedenface merged commit 3cd9f8f into nagios-plugins:maint Jun 20, 2018
@chicks-net
Copy link

Where will the style guide be once it is available? Or where should we keep an eye out for the style guide announcement?

@hedenface
Copy link
Contributor

It will be available in each of the repos as CODING_STYLE.md once complete.

@mjtrangoni mjtrangoni deleted the gcc73-fixes branch June 20, 2018 16:21
@mjtrangoni mjtrangoni mentioned this pull request Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants