Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with ChartJS v3 #26

Merged
merged 4 commits into from Jun 14, 2021

Conversation

MartijnVerkleij
Copy link
Contributor

@MartijnVerkleij MartijnVerkleij commented May 3, 2021

Hello there! I need to be honest with you, I have not tested this code at all, but this is essentially what came out of my attempts to get the plugin working again. So, it may only bring back rudimentary compatibility.

I have used code from someone else as you can see. I need to get in touch to confirm that this is okay. I have just received confirmation that this is not an issue.

Fixes #24
Fixes #25

@MartijnVerkleij
Copy link
Contributor Author

Apologies for the messy commits whilst trying to fix the Travis pipeline 😊

@dregad
Copy link

dregad commented May 11, 2021

Dear @nagix it would be awesome if you could merge this and publish a new release of this excellent chart.js library ! Thanks in advance.

@pkunszt
Copy link

pkunszt commented May 15, 2021

yes please @nagix, this would make the plugin usable again with the latest version of chartJS. Thanks!

@DmytroLitvinov
Copy link

Hi @nagix ,
Thanks a lot for that plugin. It would be nice if we can keep alive that plugin :)

@mano3m
Copy link

mano3m commented May 23, 2021

This looks good. Could someone create a minified version of the updated plugin? Thanks!

@blikblum
Copy link

I just tested and those changes are not enough to get working with chartjs v3.

I created a working branch at https://github.com/blikblum/chartjs-plugin-colorschemes/tree/v3

Time allowing i will do a proper PR

@nagix nagix self-assigned this Jun 14, 2021
@nagix nagix added the enhancement New feature or request label Jun 14, 2021
@nagix nagix added this to the v1.0.0 milestone Jun 14, 2021
@nagix
Copy link
Owner

nagix commented Jun 14, 2021

@MartijnVerkleij Thank you for your contribution! This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin doesn't work with Chart.js 3.x.x Error: Cannot find module 'rollup/bin/rollup'
8 participants