Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not verify if missing arg #48

Closed
jamesdanged opened this issue Oct 4, 2017 · 5 comments
Closed

should not verify if missing arg #48

jamesdanged opened this issue Oct 4, 2017 · 5 comments

Comments

@jamesdanged
Copy link

Great framework! I noticed though that verify doesn't properly seem to check for different number of arguments/missing arguments.

class Foo {
  bar(a?: number, b?: number) {}
}
let mockFoo = mock(Foo)
let foo = instance(mockFoo)
foo.bar(5)
verify(mockFoo.bar(5, 6)).called()

This should throw a verification error but doesn't.

@NagRock
Copy link
Owner

NagRock commented Oct 4, 2017

Hi! Thanks for motivating words and reporting issue. Can you give me version number you are using?

@jamesdanged
Copy link
Author

I'm on 2.2.1.

@NagRock
Copy link
Owner

NagRock commented Oct 4, 2017

Oh! This is very important issue, thanks for reporting this. I will fix this asap.

@NagRock
Copy link
Owner

NagRock commented Oct 4, 2017

@jamesdanged hi again, this issue should be fixed in version 2.2.2 https://github.com/NagRock/ts-mockito/releases/tag/v2.2.2

Please reopen this issue if something still works wrong.
Once again thanks for reporting this!

@NagRock NagRock closed this as completed Oct 4, 2017
@jamesdanged
Copy link
Author

Works great now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants