Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In protractor tests, expectStateNamesToBe() sometimes fails #732

Open
GoogleCodeExporter opened this issue May 11, 2015 · 1 comment
Open

Comments

@GoogleCodeExporter
Copy link

In core/tests/protractor/editorAndPlayer.js it used to be the case that the 
"editor.expectStateNamesToBe(['state1', 'state2', 'END'])" line came just 
before the previous "editor.moveToState('state2')" line. However, on Jacob's 
computer, the expectStateNamesToBe(['state1', 'state2', 'END']) call 
consistently failed: the state names observed by protractor were ['', '', '']. 
On Sean's computer, though, it consistently passed.

In order to get integration tests passing on Jacob's computer, these two lines 
were switched. However, this is essentially a hack, so if you run into any 
further issues with this or similar tests, please add information to this issue 
so we can figure out what is actually going on.

So far, we have tried removing the moveToState() line altogether, and adding a 
waitForSystem() call, but none of these work.

Original issue reported on code.google.com by jacobdav...@gmail.com on 27 Apr 2015 at 3:14

@GoogleCodeExporter
Copy link
Author

Note: this refers to the second expectStateNamesToBe() call (the one that 
happens before discardChanges()) in the following test:

describe('Full exploration editor', function() {
  it('should handle discarding changes, navigation, deleting states, ' +
      'changing the first state, displaying content, deleting rules and ' +
      'switching to preview mode', function() {

Original comment by s...@seanlip.org on 27 Apr 2015 at 3:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant