You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Branch name: experimental-gadgets-in-learner-view
Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=b220a42b3232dbd02c517547171157f7
5067ccb2&name=experimental-gadgets-in-learner-view
Purpose of code changes on this branch:
- Move oppia-gadget-panels into proper position relative to the State cards.
- ScoreBar hooked up to the existing Parameters system.
- Gets all tests passing but one (detailed below).
When reviewing my code changes, please focus on:
- @amitdeutsch, 2 of 3 panels are near correct, requesting advice on getting
the right side panel properly positioned within existing CSS. I flagged
comments for the specific locations in question in player.html in this commit.
Appreciate any suggestions you have. You can load functional demo via /admin/
and load about_oppia_w_gadgets.yaml
- @sll: All tests pass but one assert schema[SCHEMA_KEY_TYPE] in
ALLOWED_SCHEMA_TYPES, this is for a custom schema item ADVICE_OBJECT_SCHEMA in
AdviceBar.py. Any suggestions on best way to resolve?
- Overall: any suggested improvements are much appreciated.
After the review, I'll merge this branch into: N/A. A few areas are still
flagged EXPERIMENTAL and will need at least 1 more commit to tidy up before
merging to develop.
Original issue reported on code.google.com by anu...@google.com on 30 Apr 2015 at 6:46
The text was updated successfully, but these errors were encountered:
Done my section; reassigning to Amit.
Note: new commit URL is at
https://code.google.com/p/oppia/source/detail?r=b761ad1587e43deb6091473f3715397d084797ad&name=experimental-gadgets-in-learner-view
and Amit, I think the only file needing your attention is
https://code.google.com/p/oppia/source/diff?spec=svnb220a42b3232dbd02c517547171157f75067ccb2&name=experimental-gadgets-in-learner-view&r=b220a42b3232dbd02c517547171157f75067ccb2&format=side&path=/extensions/skins/conversation_v1/player.html
Thanks!
Original comment by s...@google.com on 30 Apr 2015 at 8:59
Original issue reported on code.google.com by
anu...@google.com
on 30 Apr 2015 at 6:46The text was updated successfully, but these errors were encountered: