Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request #741

Open
GoogleCodeExporter opened this issue May 11, 2015 · 4 comments
Open

Code review request #741

GoogleCodeExporter opened this issue May 11, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Branch name: experiment-speech

Link to the relevant commit(s):
  (1) https://code.google.com/p/oppia/source/detail?name=experiment-speech&r=97d93896826a4fd3dd39b5adbd0a548880601016
  (2) https://code.google.com/p/oppia/source/detail?name=experiment-speech&r=2c9e7ec9b6d890c99f623af14abf68811a686dde

Purpose of code changes on this branch: add speech recognition to TextInput 
field.


When reviewing my code changes, please focus on:
- Jacob: UI and code (there's not much!)
- Amit: UI
- Sergio, Javier, Eugenio: code (any thoughts/questions?)


After the review, I'll merge this branch into: N/A. Based on the review 
comments from Amit and Jacob, I'll probably redo this (together with adding the 
ability for exploration editors to customize the speech recognition language) 
in a new branch.

Original issue reported on code.google.com by s...@seanlip.org on 5 May 2015 at 3:56

@GoogleCodeExporter
Copy link
Author

Further notes (pulling this from an email I was about to send):

----

Sergio, Javier, Eugenio: thanks for the chat this morning! I went through your 
commit and have reimplemented it as an option for string input fields in 
general (in our forms framework). Please have a look at these two commits, and 
leave comments if you have any questions -- I'd be happy to explain. You can 
also checkout this branch by going to oppia/ and running:

    git pull
    git checkout experiment-speech

and it should work on your dev server.

----

Jacob, Amit: Sergio, Javier and Eugenio have implemented speech recognition in 
Chrome (it does not work in other browsers). Based on their work, I've modified 
the input field for text input to accept speech (only in Chrome; it degrades 
gracefully in the non-webkit browsers).

Please try it out in both Chrome and Firefox and see if you like how it looks 
-- the simplest way is to checkout the experiment-speech branch, load the "Lazy 
Magician" demo exploration, and play through the first state. Do either of you 
have any thoughts on the UI aspects? I think this is actually pretty nice and 
am strongly considering bringing it into mainline, but am not sure if there's 
any considerations I'm overlooking.

Thanks!

Original comment by s...@seanlip.org on 5 May 2015 at 4:01

@GoogleCodeExporter
Copy link
Author

FYI I made a follow-on commit here to fix a bug (thanks Sergio!):

    https://code.google.com/p/oppia/source/detail?name=experiment-speech&r=136bc36b62bd524ae7ec9f761fee5949a41c1474

Original comment by s...@seanlip.org on 5 May 2015 at 6:00

@GoogleCodeExporter
Copy link
Author

Added follow-on commit here based on Amit's UI suggestions:

    https://code.google.com/p/oppia/source/detail?name=experiment-speech&r=2fe5d5e4229b722f7afd78141146694ecacf531f

Amit, question for you: what should this feature look like for a textarea 
(multiple lines)?

Original comment by s...@seanlip.org on 6 May 2015 at 6:51

@GoogleCodeExporter
Copy link
Author

Attached screenshot.

Original comment by amitdeut...@google.com on 7 May 2015 at 4:49

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant