Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP2 option #29

Closed
1 task
nakabonne opened this issue Oct 2, 2020 · 4 comments
Closed
1 task

Support HTTP2 option #29

nakabonne opened this issue Oct 2, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@nakabonne
Copy link
Owner

nakabonne commented Oct 2, 2020

  • Make it possible to switch to send HTTP/2 requests when supported by the server

Only tiny changes are required because all we have to do is just pass to the Vegeta API.

@nakabonne nakabonne added the good first issue Good for newcomers label Oct 2, 2020
@shubham14bajpai
Copy link
Contributor

shubham14bajpai commented Oct 6, 2020

Hi @nakabonne I would like to work on this. The changes would be as simple as

opts.Attacker = vegeta.NewAttacker(
	vegeta.Timeout(opts.Timeout),
	vegeta.Workers(opts.Workers),
	vegeta.MaxWorkers(opts.MaxWorkers),
	vegeta.MaxBody(opts.MaxBody),
	vegeta.KeepAlive(opts.KeepAlive),
	vegeta.HTTP2(true),
)

in the below file. Right? Or do we need to identify somehow whether the server supports HTTP2? Just wanted to make sure I understand the changes required before raising a PR.

opts.Attacker = vegeta.NewAttacker(

@nakabonne
Copy link
Owner Author

@shubham14bajpai

The changes would be as simple as

Exactly. All we have to do is just pass the value received from the flag to vegeta. Look forward to your PR!

@shubham14bajpai
Copy link
Contributor

@nakabonne I have raised a PR for the same #49

@nakabonne
Copy link
Owner Author

Closing since this was resolved by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants