Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying to use the libiconv-1.15 #17

Merged
merged 1 commit into from Aug 8, 2017
Merged

Modifying to use the libiconv-1.15 #17

merged 1 commit into from Aug 8, 2017

Conversation

sambitdash
Copy link
Contributor

libiconv-1.14 does not build on newer versions of Ubuntu. This has been reported in the issue #16. This PR is to address the same.

@sambitdash
Copy link
Contributor Author

The changes should not affect Windows OS.

@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage decreased (-0.3%) to 87.097% when pulling bc4ff67 on sambitdash:master into 166f5d4 on nalimilan:master.

@codecov-io
Copy link

Codecov Report

Merging #17 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   87.43%   87.09%   -0.34%     
==========================================
  Files           2        2              
  Lines         183      186       +3     
==========================================
+ Hits          160      162       +2     
- Misses         23       24       +1
Impacted Files Coverage Δ
src/StringEncodings.jl 87.86% <0%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166f5d4...bc4ff67. Read the comment docs.

@nalimilan nalimilan merged commit 2631c9a into JuliaStrings:master Aug 8, 2017
@nalimilan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants