New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for XMediaNotificationTrackSelector #140
Conversation
Hey, First of all, thanks for sending this PR, It seems like a great idea. I wasn't rooted before so wasn't able to test right away. Anyway, it's currently crashing on notification building on my Nexus 6 FATAL EXCEPTION: main
Process: naman14.timber:main, PID: 2261
android.app.RemoteServiceException: Bad notification posted from package naman14.timber: Couldn't expand RemoteViews for: StatusBarNotification(pkg=naman14.timber user=UserHandle{0} id=27905579 tag=null score=0 key=0|naman14.timber|27905579|null|10210: Notification(pri=0 contentView=naman14.timber/0x109008c vibrate=null sound=null defaults=0x0 flags=0x62 color=0xff403f4d category=transport actions=3 vis=PUBLIC))
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1507)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:114) I am guessing that some resource is probably null somewhere. Any Idea? |
I forgot to push some fixes to the module into the Xposed repo, update it to 1.1 and it should work. |
Yeah, its working fine with module version 1.1. There's heavy lag though due to looping on every playlist item. Especially if shuffling all songs, the lag is upto 4-5 seconds. I am looking into fixing that, will probable require changes from lib side also |
I don't experience so heavy lags, but I can imagine they get bigger if it has to load more than 10 items. Just send me a message when you're done rewriting, and I'll look at what I can do :) |
BTW, will you merge these changes now or do you want to update your MusicService first? |
I will update MusicService first so that lag is eliminated |
Add support for XMediaNotificationTrackSelector
Thanks for merging! Looking forward to a release! :) |
More information to be found here.
To use that feature, users also need to have the Xposed module and Xposed installed. This won't break the app for users without the module, of course.