Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI to test PRs and branches for successful builds #4

Closed
afollestad opened this issue Feb 2, 2019 · 2 comments
Closed

Add CI to test PRs and branches for successful builds #4

afollestad opened this issue Feb 2, 2019 · 2 comments
Assignees
@naman14
Labels
tech debt Internals need to be cleaned up or improved by the devs. Or dev ops stuff, like CI.

Comments

@afollestad
Copy link
Collaborator

afollestad commented Feb 2, 2019 •
edited

All that you gotta do is create an account on Travis.ci and add the repository. I can add the configuration to the repo here when you're ready, and we can add a badge to the README.

IMO this is very important because we want to make sure master is building successfully and that PRs won't break anything if they are merged (especially if unit tests are added to the repo). 😁
@afollestad afollestad added the tech debt Internals need to be cleaned up or improved by the devs. Or dev ops stuff, like CI. label Feb 5, 2019
@naman14
Copy link
Owner

naman14 commented Feb 5, 2019

Added the travis config and build status in readme

@naman14 naman14 closed this as completed Feb 5, 2019
@afollestad
Copy link
Collaborator Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naman14 naman14

Labels
tech debt Internals need to be cleaned up or improved by the devs. Or dev ops stuff, like CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afollestad @naman14