fix ReplyListener on standalone rpc with custom publisher_options #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @alfaro28. |
mattbennett
approved these changes
Sep 29, 2021
mattbennett
added a commit
that referenced
this pull request
Sep 29, 2021
#718 fixes the standalone rpc reply listener to honour the amqp uri passed into the rpc client. the reconnection tests have revelealed another bug in the implementation now that the reply listener is using the correct uri. check_for_lost_replies will see a "server unexpectedly closed" OSError when reconnecting after a broken connection. this is because it uses an existing connection from the connection pool, some of which will have previously been connected. the above PR was merged without a green CI build (because _reasons_), so the fix is being addded as a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standalone rpc ReplyListener does not inherit any
amqp_uriorssloptions passed to the constructor of its owning client.