Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline body horizontal position is not syncing with header #550

Open
ghost opened this issue Apr 9, 2019 · 3 comments
Open

Timeline body horizontal position is not syncing with header #550

ghost opened this issue Apr 9, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Apr 9, 2019

Timeline body horizontal position is not syncing when scrolling on a small screen with shift+mouse wheel. Scrolling solely with mouse down/drag works fine.
I've noticed that on a screen where window.outerWidth = 1920; window.innerWidth = 1920 it does work fine, but on a screen where window.outerWidth = 1284; window.innerWidth = 1280 it is completely broken.

To Reproduce

  1. Provide visibleTimeStart and visibleTimeEnd on <Timeline /> Declaration.
  2. Provide a callback for onTimeChange. Callback's body is taken from the readme.md on how to limit visible time. (here)
  3. Use shift+mouse scroll to horizontally scroll.
  4. Approach the edge of visible time.
  5. Header is not moving yet timeline calendar's body is

Codesandbox
https://codesandbox.io/s/5mvzx1m3jx

Expected behavior
Calendar's body should not move and should be in sync with header / vice versa.

Screenshots
gnUiwBJY8M

Library Version
0.23

environment

  • OS: windows 10
  • Browser chrome
  • Version 73.0.3683.86 (64-bit)
@ghost ghost changed the title Header position does not sync with timeline Timeline body horizontal position is not syncing with header Apr 9, 2019
@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Apr 9, 2019

I am going to release a reimplementation of the headers hopefully this weekend or early next week (the code has been merged but not yet released). I will your problem out. I think it will be solved

#349

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Jul 31, 2019

@hellooperatorpatchmethrough have you upgraded to the new headers? are you still having the issue?

@agustingabiola
Copy link

@Ilaiwi Hello and thanks for your library. I was trying to limit the time and encounter the same issue with the scrolling of the rows not syncing with the header. Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants