Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Carthage #9

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Carthage #9

merged 3 commits into from
Jan 8, 2018

Conversation

adriano-s
Copy link
Contributor

What does this Pull Request do?

add carthage setup instructions

Where should the reviewer start?

README.md

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets/issues?

Screenshots (if appropriate)

Overall Developemnt requirements:

  • If you added new Header files, did you update Header-ios-objc-foundation-nmxcore.h or related header files, so the code documentation is able to retrieve your new files?
  • Did you write pretty printable code comments for added classes, properties or functions?
  • If you added properties, did you Nullability annotations? --> _Nullable, _Nonnull
  • If you added functions, did you Nullability annotations? --> nullable, nonnull, null_resettable, null_unspecified
  • Did you generate a new documentation file via jazzy-command?
  • Did you perform pod lib lint NMXCore.podspec and pod lib lint NMXCoreDylib.podspec
  • Did you test your code with Unit tests?
  • Did the test coverage increase / did maintain the same level? --> If not, why?

Release Management

  • Did you update the README.md with the latest version you are using
  • Did you perform pod spec lint NMXCore.podspec and pod spec lint NMXCoreDylib.podspec
  • Make the reviewer aware to pod trunk push NMXCore.podspec --verbose and pod trunk push NMXCoreDylib.podspec --verbose after the review. Or do it yourself.

Further Questions

  • Is there a blog post?
  • Does the knowledge base need an update?
  • Does this add new dependencies which need to be added to the podspec file?

@coveralls
Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage remained the same at 99.8% when pulling e553b74 on carthage into c4c185f on master.

@Lepidopteron Lepidopteron merged commit c9e88f5 into master Jan 8, 2018
@Lepidopteron Lepidopteron deleted the carthage branch January 8, 2018 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants