Passing a dom element as the selector throws error

[shidhincr]

Assume the following code:

import {$} from 'dollarDom'

const domElement = document.getElementById('#someElementID');
console.log(domElement); // This prints the dom element

$(domElement).on('click', function() { alert(this.innerHTML) }); // throws error

The above code throws the error:

Issue:

the $ method is not checking the type of the selector -- so ideally, it should check if the selector is a string or a dom node before calling the .trim() / or other actions on the selector.

[ndajr]

Assuming you intend to use DolarDOM, why would you use the getElementById? Why not $('#someElementID').on('click ... ?

[shidhincr]

Sometimes, there are chances that people pass the entire DOM element as the selector. ( Mostly anyone who comes from the jQuery background would've done that ).

Ideally, we need to handle that situation gracefully, instead of the code throwing the unhandled exception.