-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of web root #18
Comments
Hi, and thanks very much :) Hopefully that should not be too hard indeed. I'll take a look very soon. |
@kungfoolfighting The latest release 2.7.0 should now support what you need. https://github.com/nanawel/our-shopping-list/releases/tag/2.7.0 If you're serving multiple instances on the same host, please read https://github.com/nanawel/our-shopping-list#-notes-when-serving-multiple-instances-on-different-web-roots |
Oh wow, thanks a bunch for the super speedy implementation of this! Greatly appreciated. I will give it a try today. |
I have tested this now and I can't quite get it to work with a reverse proxy.
It loads almost everything but doesn't show any boards. So it is not using the base url for that specific request. Other requests do use the base url (for images and scripts etc.). |
Hi, You did not mention you set the services:
app:
image: ...
...
environment:
BASE_URL: '/osl/' |
Oh yeah, sorry, I omitted mentioning that, since I thought the non-proxy version would not work at all with that url if I hadn't set the base url. It looks like this:
|
Also small correction: since I am in single board mode I should have said "it doesn't list any lists" rather than "it doesn't list any boards". |
You're right. There seems to be a bug with singleboard mode. Let me take a look. |
That should be fixed now with 2.7.1. Tell me if it works as expected in your environment. |
Works great now, thanks so much! |
Hello,
I would like to be able to reach OSL via something like https://myserver/osl/ rather than having to configure a different hostname for this service or a different port.
I have tried creating clever nginx reverse proxy rules to achieve this by rewriting the contents of all the source files before they are served to the clients. This has been a bunch of work and still doesn't support every necessary function.
It would be great if this could be added as a configuration parameter, where you can configure the webroot yourself. For example to "osl".
I hope this would not be too difficult to do.
Thanks for this great project. We have been using it for the last months and it is exactly what I was looking for: A lightweight app, that we can use to coordinate our in-store shopping and planning.
The text was updated successfully, but these errors were encountered: