Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.7.0] Tag Search download jobs continue into endless series of page queries #25

Closed
Akio-kun opened this issue Jul 22, 2014 · 4 comments

Comments

@Akio-kun
Copy link

This has happened to every one of my searches so far. I'll pick terms from the Nijie wiki and my image notes until I find a search with promising results and themes—then copy the Japanese language terms and repeat my search in the program. Everything goes great until I notice the batch status message ticking up another search page every second and no new downloaded/skipped files.

I've let one search run for 1200 pages before I got tired of it (all my tag searches were 5 pages results or less, so far). After which point, it seems to present the same termination problems I mentioned in issue #23 (though in this case, it always searches endlessly even if it's the only job queued).

Pressing the Clear All or Delete button will cause the hidden runaway thread that can't be controlled by the program again, but will restart (still hidden) at page 1 if another job is initiated. Restarting the program seems to kill the process. However, I just found that pushing Stop on the endlessly searching job brings up the correct end-of-job popup dialog, with a corresponding note in the log. So, hitting Stop and then delete or clear before another job is added into the queue allows functions to proceed normally.

The download job also exits cleanly if the search reaches the End Page value entered by the user on the Add Job setup screen. The total number of submissions in a web search appears below the essential 'file folder' navigation tabs in tiny letters, immediately following a bold string like

タグ検索:産卵 の結果(部分一致) 169 枚

Hopefully this number can be ascretained through the API in a method other than brute force~

@Akio-kun Akio-kun changed the title [1.0.6.1] Tag Search download jobs continue into endless series of queuing pages with no further results [1.0.6.1] Tag Search download jobs continue into endless series of page queries Jul 22, 2014
@Akio-kun
Copy link
Author

Incidentally, in Tag searches, I haven't encountered the "queue jamming" problem which can occur at the termination of normal image searches issue #23. Yay! ^^

EDIT: Yeah, apparently two Tag jobs can jam in the queue, at least with a gallery present after. See my comment in issue #21

@Nandaka
Copy link
Owner

Nandaka commented Jul 22, 2014

ah, the detection is based on the presence of Next page button on the page, as the starting page can be anywhere, so the total image count is not considered.

I can also add additional check, if the pages contains 0 image, then stop getting the next page/set next page avaliable = false.

@Akio-kun
Copy link
Author

Akio-kun commented Aug 3, 2014

[1.0.7.0] Despite the new accurate "total image" count obtained when searching, tag download jobs continue ad infinitum if one doesn't enter a page or image limit.

@Akio-kun Akio-kun changed the title [1.0.6.1] Tag Search download jobs continue into endless series of page queries [1.0.7.0] Tag Search download jobs continue into endless series of page queries Aug 3, 2014
@Nandaka
Copy link
Owner

Nandaka commented Aug 3, 2014

Nandaka added a commit that referenced this issue Aug 3, 2014
@Nandaka Nandaka closed this as completed Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants