Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--verbose table formatting is off #1005

Closed
denisdefreyne opened this issue Nov 30, 2016 · 5 comments
Closed

--verbose table formatting is off #1005

denisdefreyne opened this issue Nov 30, 2016 · 5 comments

Comments

@denisdefreyne
Copy link
Member

On sites that take long to compile, the format of the table outputted by compile --verbose is off:

               | count    min    avg    max     tot
---------------+-----------------------------------
md_to_html_ext |  2396  0.00s  0.00s  0.01s   0.32s
           erb |  2514  0.00s  0.18s  1.18s  462.42s
     redcarpet |  2396  0.00s  0.01s  0.28s  30.60s
          sass |     2  0.39s  2.19s  4.00s   4.38s
@connorshea
Copy link

This is the relevant method:

def print_profiling_feedback

@connorshea
Copy link

Should it use a terminal table generation gem, or is that excessive for this? :)

Regardless, it should probably allow for an arbitrary length.

@connorshea
Copy link

@ddfreyne I'd like to contribute a fix for this, should we make it dynamically resize somehow or just update it to fit, e.g. 1000.00s?

@denisdefreyne
Copy link
Member Author

@connorshea I’m OK with either! Dynamically resizable would be nice, though.

Preferably without an external table generation gem. I prefer to avoid adding a dependency unless necessary, and even then I’ll prefer reimplementing something in Nanoc to pulling in a dependency.

@denisdefreyne
Copy link
Member Author

(You might be interested in https://github.com/nanoc/nanoc/blob/master/lib/nanoc/checking/runner.rb#L115 for inspiration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants