Let #[] create single-item dependencies if possible #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
denis/optimize-single-item-dependencies
branch
from
a644e4b
to
5a0f2cd
Compare
denisdefreyne
force-pushed
the
denis/optimize-single-item-dependencies
branch
from
5a0f2cd
to
2ce0f04
Compare
denisdefreyne
force-pushed
the
denis/optimize-single-item-dependencies
branch
from
2ce0f04
to
7bd3b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This changes
@items[]so that if there is a single exact match, no dependency on the item collection is created.(Same for layouts.)
See source comments for details.
This PR can be a bit tough to review, but you can look through the commits individually. The first commit is the actual change of letting
#[]not create dependencies on the item/laout collection, while the second commit removesIdentifiableCollection#[], which is no longer needed and probably should not be used anyway.To do
IdentifiableCollection’s#object_matching_globand#object_with_identifiermethods (since#[]is gone).Related issues
Fixes, hopefully, #1605.