Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained hamster gem with immutable-ruby #1655

Closed
graaff opened this issue Jun 14, 2023 · 2 comments · Fixed by #1656
Closed

Replace unmaintained hamster gem with immutable-ruby #1655

graaff opened this issue Jun 14, 2023 · 2 comments · Fixed by #1656

Comments

@graaff
Copy link

graaff commented Jun 14, 2023

The hamster gem appears to be no longer maintained, and has compatibility issues with ruby30 and newer versions. See for example hamstergem/hamster#254 and hamstergem/hamster#252

In the hamster issue a reference is made to a maintained fork: https://rubygems.org/gems/immutable-ruby. This should be a drop-in replacement with just the top level class name to change (if the documentation is to be believed :-)

I have not investigated whether the incompatibilities affect nanoc itself, it may be that nanoc only uses code paths that are unaffected by these incompatibilities, given that it only uses Vector and Set (and not OrderedSet). Still the missing ordered_set dependeny may lead to load errors later.

I'm also the Gentoo maintainer of nanoc and currently nanoc is stuck in Gentoo on ruby 3.0 only support because of this issue. We will be phasing out ruby30 before september (due to openssl 1.1.1 support stopping at that time) and it would be great if we can keep nanoc and support it also with ruby 3.1.

@denisdefreyne
Copy link
Member

Thanks for reporting. I created #1656 which should take care of this.

@graaff
Copy link
Author

graaff commented Jun 15, 2023

Great! Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants