Make Checksummer faster and more correct #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
denis/faster-checksummer
branch
from
fd9aedf
to
0ff8793
Compare
The new implementation is faster because of two reasons: - It more aggressively avoids calculating checksums of already-calculated items - It effectfully updates a hash rather than using Immutable::Set It is also more correct because it replaces use of <recur> with a numerical reference to a previously-seen object. Each newly checksummed object will have a number suffix, e.g. `Array#5<…>`. Each previously seen object will have an @-reference, e.g. `Array#9<@4,@5,>`. This will invalidate existing stored checksums in Nanoc sites, but it is unavoidable and worth the tradeoff.
denisdefreyne
force-pushed
the
denis/faster-checksummer
branch
from
0ff8793
to
c37e8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
The new implementation is faster because of two reasons:
Preliminary tests suggest a 30% speedup, but I have not at all tested this out properly.
It is also more correct because it replaces use of with a numerical reference to a previously-seen object.
Each newly checksummed object will have a number suffix, e.g.
Array#5<…>. Each previously seen object will have an @-reference, e.g.Array#9<@4,@5,>.This will invalidate existing stored checksums in Nanoc sites, but it is unavoidable and worth the tradeoff.
To do
Related issues
This does not fix #1692 yet, but it brings the checksummer in a better state to handle it.