Out of bounds read for keepalive packets

[alexbakker]

If a keepalive packet is received with a smaller size than expected ((16 bytes for the ip + 2 bytes for the port) * 8), an out of bounds read occurs. This results in peers getting added to the list with seemingly random ip:port combo's.

I suggest fixing this issue by looking at the size of the packet and only parsing as many peers as the size allows, up to 8 peers.

[argakiig]

fixed in #704 feel free to re-open if you do not feel it is resolved

[inkeliz]

I think it still not working, or not as I expect. The node doesn't reply the client if less than 8 peers is sent. It's the correct behavior?

For instance, the message:

5243120F0D020080 000000000000000000000000000000000000

It only includes one single IP, the node didn't reply it. However send "more zeroes" (reaching = 144 bytes) it works:

5243120F0D020080 000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 

Have any reason to not reply the first message, when have less than 8 ips?

[cryptocode]

@inkeliz the node always sends 8 entries, initializing to zero if there's not enough peers. A packet with less than 8 is considered invalid. So the behavior you see is correct.